-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add firewall_id
field for NodeBalancers
#364
Add firewall_id
field for NodeBalancers
#364
Conversation
fixing verification and merging all commits (linode#347)
I think this field belongs to |
Ah you're right, not sure if it should be in the returning object too though? I see your comment on the google doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after you implement @zliang-akamai feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🎉
22eb395
into
linode:feature/nodebalancer-firewall
📝 Description
Adds firewall_id to NodeBalancer struct
✔️ How to Test
Uncomment changes related to firewall ids in setupNodeBalancer. Currently cannot have test with firewall as there is no availability in the region with api.dev and a null point error when we use api.linode.
make ARGS="-run TestNodeBalancer_Create_create" fixtures